Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created an entry-point for rqt_topic in setup.py #16

Merged
merged 5 commits into from
Mar 19, 2021
Merged

Created an entry-point for rqt_topic in setup.py #16

merged 5 commits into from
Mar 19, 2021

Conversation

ahcorde
Copy link

@ahcorde ahcorde commented May 14, 2020

Fixed package to run with ros2 run rqt_topic rqt_topic. Related to this issue ros-visualization/rqt_console#20

Signed-off-by: ahcorde [email protected]

@ahcorde ahcorde added the bug label May 14, 2020
@ahcorde ahcorde requested a review from jacobperron May 14, 2020 10:54
@ahcorde ahcorde self-assigned this May 14, 2020
@dirk-thomas
Copy link
Contributor

Please keep the changes in a pull request focused on one semantic change described in the title. If necessary create multiple PRs for orthogonal changes.

@ahcorde ahcorde changed the title Fixed package to run with ros2 run Changed the build type to ament_python and fixed package to run with ros2 run May 14, 2020
@jacobperron
Copy link

I agree with @dirk-thomas, The fix for the connected issue is adding the entry point (and maybe the setup.cfg file?). The other changes to the setup.py are unrelated and can be done in a separate PR.

Also, please update the title to relate to the fix. rqt_topic is already of build type ament_python, so the current title is misleading.

@ahcorde ahcorde force-pushed the ahcorde/fix_run branch 3 times, most recently from ae51e31 to 18b296f Compare May 27, 2020 16:49
@ahcorde
fixed description
ff1f2e5 
Signed-off-by: ahcorde <[email protected]>
@ahcorde
Copy link
Author

ahcorde commented May 27, 2020

Moved to another PR version and license changes #17

@jacobperron
Copy link

Please update the PR title; this package is already an ament_python package.

@ahcorde ahcorde changed the title Changed the build type to ament_python and fixed package to run with ros2 run Created an entry-point for rqt_topic in setup.py May 28, 2020
@wjwwood
Copy link
Member

wjwwood commented Mar 19, 2021

@jacobperron @ahcorde I'm looking to release this for the upcoming galactic fork from rolling, seems like this should get in? So friendly bump :)

@cottsay
Copy link
Member

cottsay commented Mar 19, 2021

@ros-pull-request-builder retest this please

cottsay
cottsay approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this drops the rqt_topic command from /opt/ros/foo/bin, but I think this is actually the right thing to do. A change, nonetheless.

@cottsay cottsay merged commit 944f273 into dashing-devel Mar 19, 2021
@cottsay cottsay deleted the ahcorde/fix_run branch March 19, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cottsay cottsay cottsay approved these changes

@jacobperron jacobperron Awaiting requested review from jacobperron

Assignees

@ahcorde ahcorde

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahcorde @dirk-thomas @jacobperron @wjwwood @cottsay